GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5551
[FLINK-8736][network] fix memory segment offsets for slices of slices being
wrong
## What is the purpose of the change
[FLINK-8588] introduced memory segment offsets to the `Buffer` classes but
the offsets of slices of slices do not account for their parent's slice offset.
Also, unit tests for this added feature were missing.
## Brief change log
- store the absolute `memorySegmentOffset` in `ReadOnlySlicedNetworkBuffer`
instances to fix memory segment offsets for slices of slices
- clean up `RecordWriterTest`: remove the `PowerMockRunner` which is not
needed anymore
- further cleanup and minor improvements, e.g. additional assertions
## Verifying this change
This change added tests and can be verified as follows:
- adapted `ReadOnlySlicedBufferTest` to include tests for the memory
segment offsets
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-8736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5551.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5551
----
commit 9a93b284480ff7086797d44dee865e7e3f4331db
Author: Nico Kruber <nico@...>
Date: 2018-02-20T17:06:41Z
[hotfix][network] remove PowerMockRunner from RecordWriterTest
commit 6c1836fe9661adc600c85feb9a2d792f83fe49fe
Author: Nico Kruber <nico@...>
Date: 2018-02-20T17:07:02Z
[hotfix][network] various minor improvements
commit dd37dfe5506231523dbe9121d04d0b2b0af002ca
Author: Nico Kruber <nico@...>
Date: 2018-02-21T15:30:53Z
[hotfix][network] initialize SingleInputGate#enqueuedInputChannelsWithData
with the right size
commit 30412f7dd83eacc57c55c817c9e7285dd8d561e4
Author: Nico Kruber <nico@...>
Date: 2018-02-21T16:09:31Z
[FLINK-8736][network] fix memory segment offsets for slices of slices being
wrong
----
---
