[
https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374091#comment-16374091
]
ASF GitHub Bot commented on FLINK-8538:
---------------------------------------
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170194561
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptorValidator.scala
---
@@ -27,13 +27,27 @@ class ConnectorDescriptorValidator extends
DescriptorValidator {
override def validate(properties: DescriptorProperties): Unit = {
properties.validateString(CONNECTOR_TYPE, isOptional = false, minLen =
1)
- properties.validateInt(CONNECTOR_VERSION, isOptional = true, 0,
Integer.MAX_VALUE)
+ properties.validateInt(CONNECTOR_PROPERTY_VERSION, isOptional = true,
0, Integer.MAX_VALUE)
}
}
object ConnectorDescriptorValidator {
+ /**
+ * Key for describing the type of the connector. Usually used for
factory discovery.
+ */
val CONNECTOR_TYPE = "connector.type"
+
+ /**
+ * Key for describing the property version. This property can be used
for backwards
--- End diff --
Two spaces here...
> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>
> Key: FLINK-8538
> URL: https://issues.apache.org/jira/browse/FLINK-8538
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Xingcan Cui
> Priority: Major
>
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should
> be added. This issue includes improving the existing JSON descriptor with
> validation that can be used for other connectors as well. It is up for
> discussion if we want to split the KafkaJsonTableSource into connector and
> format such that we can reuse the format for other table sources as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
