Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5560#discussion_r170314219
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
 ---
    @@ -289,7 +290,7 @@ public void invoke() throws Exception {
     
                        // wait forever (until canceled)
                        synchronized (this) {
    -                           while (error == null && lastCheckpointId < 
numCalls) {
    --- End diff --
    
    The only locations where a notify was called is when the error is set to 
`!= null`. Furthermore I think, the testing task is not intended to complete in 
case that `lastCheckpointId >= numCalls`. Alternatively, one could fix the 
problem by executing the `lastCheckpointId` under the lock as well as the 
trigger of `awaitLatch`.


---

Reply via email to