Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5579#discussion_r170868446
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAQueryableStateFsBackendITCase.java
---
@@ -18,28 +18,99 @@
package org.apache.flink.queryablestate.itcases;
+import org.apache.flink.configuration.ConfigConstants;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.configuration.QueryableStateOptions;
+import org.apache.flink.configuration.TaskManagerOptions;
+import org.apache.flink.configuration.WebOptions;
+import org.apache.flink.queryablestate.client.QueryableStateClient;
import org.apache.flink.runtime.state.AbstractStateBackend;
import org.apache.flink.runtime.state.filesystem.FsStateBackend;
+import org.apache.flink.test.util.MiniClusterResource;
+import org.apache.curator.test.TestingServer;
+import org.junit.AfterClass;
import org.junit.BeforeClass;
-import org.junit.Rule;
+import org.junit.ClassRule;
import org.junit.rules.TemporaryFolder;
/**
* Several integration tests for queryable state using the {@link
FsStateBackend}.
*/
-public class HAQueryableStateFsBackendITCase extends
HAAbstractQueryableStateTestBase {
+public class HAQueryableStateFsBackendITCase extends
AbstractQueryableStateTestBase {
--- End diff --
To be honest, I'm not a huge fan of inheritance when writing tests. It is
really hard to understand whats going on and it is hard to enforce invariants
which are assumed by the base class. For example,
`AbstractQueryableStateTestBase` requires that the `ClusterClient` is set to
detached job submission. A user who does not know it and extends this test base
will almost certainly stumble across this. Ideally tests are succinct enough
that you have everything in a single class.
---
