[
https://issues.apache.org/jira/browse/FLINK-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379779#comment-16379779
]
ASF GitHub Bot commented on FLINK-8792:
---------------------------------------
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5587
@tillrohrmann could you review this PR? Thanks!
> bad semantic of method name MessageQueryParameter.convertStringToValue
> ------------------------------------------------------------------------
>
> Key: FLINK-8792
> URL: https://issues.apache.org/jira/browse/FLINK-8792
> Project: Flink
> Issue Type: Improvement
> Components: REST
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Minor
>
> the method name
> {code:java}
> MessageQueryParameter.convertStringToValue
> {code}
> should be
> {code:java}
> convertValueToString
> {code}
> or
> {code:java}
> convertStringFromValue{code}
> I think
> {code:java}
> convertValueToString
> {code}
> would be better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
