Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5595#discussion_r171208805
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java 
---
    @@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration() {
         * @param jobGraph The JobGraph to be submitted
         * @return JobSubmissionResult
         */
    -   protected abstract JobSubmissionResult submitJob(JobGraph jobGraph, 
ClassLoader classLoader)
    +   public abstract JobSubmissionResult submitJob(JobGraph jobGraph, 
ClassLoader classLoader)
    --- End diff --
    
    we could deprecate all other submit-like methods that the 
`RestClusterClient` doesn't override.


---

Reply via email to