[ https://issues.apache.org/jira/browse/FLINK-7804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392891#comment-16392891 ]
ASF GitHub Bot commented on FLINK-7804: --------------------------------------- GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5675 [FLINK-7804][flip6] YarnResourceManager does not execute AMRMClientAsync callbacks in main thread ## What is the purpose of the change *The `YarnResourceManager` registers callbacks at a `AMRMClientAsync` which it uses to react to Yarn container allocations. These callbacks, e.g., `onContainersAllocated`, modify the internal state of the YarnResourceManager. This can lead to race conditions with the `requestYarnContainer` method. To solve this problem we have to execute the state changing operations in the main thread of the `YarnResourceManager`.* ## Brief change log - *Run AMRMClientAsync callbacks in main thread* - *Fix `YarnResourceManagerTest`* ## Verifying this change This change is already covered by existing tests, such as `YarnResourceManagerTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/GJL/flink FLINK-7804 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5675.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5675 ---- commit f6c61e0c7989d6d67f784818aa94cd112f600bff Author: gyao <gary@...> Date: 2018-03-09T13:36:33Z [FLINK-7804][flip6] Run AMRMClientAsync callbacks in main thread ---- > YarnResourceManager does not execute AMRMClientAsync callbacks in main thread > ----------------------------------------------------------------------------- > > Key: FLINK-7804 > URL: https://issues.apache.org/jira/browse/FLINK-7804 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination, YARN > Affects Versions: 1.4.0, 1.5.0 > Reporter: Till Rohrmann > Assignee: Gary Yao > Priority: Blocker > Labels: flip-6 > Fix For: 1.5.0 > > > The {{YarnResourceManager}} registers callbacks at a {{AMRMClientAsync}} > which it uses to react to Yarn container allocations. These callbacks (e.g. > {{onContainersAllocated}} modify the internal state of the > {{YarnResourceManager}}. This can lead to race conditions with the > {{requestYarnContainer}} method. > In order to solve this problem we have to execute the state changing > operations in the main thread of the {{YarnResourceManager}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)