Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5669#discussion_r173455497
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka010ITCase.java
---
@@ -81,12 +81,6 @@ public void testCancelingEmptyTopic() throws Exception {
public void testCancelingFullTopic() throws Exception {
runCancelingOnFullInputTest();
}
-
--- End diff --
ah right, forgot to comment that. I found these test to be rather..._odd_.
They check behavior when not enough slots are available, but in the old code
afaik this fails before the client even submits the job, and in flip6 this
stalls as we never check whether enough slots are available (i guess with the
underlying assumption that we would just allocate more TMs until we have
enough).
---
