[
https://issues.apache.org/jira/browse/FLINK-8904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395028#comment-16395028
]
ASF GitHub Bot commented on FLINK-8904:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5670#discussion_r173746711
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendTestUtils.java
---
@@ -65,9 +67,14 @@ public static String getInvalidConfigDir() {
}
public static void pipeSystemOutToNull() {
+ previousSysout = System.out;
--- End diff --
That depends on whether we want the restore logic as "restore to previous
stdout" or "restore to default stdout" - I guess, the latter makes most sense
indeed and we do not want to encourage any other use.
-> I'll change the commits accordingly
> Flink-client tests do not restore previous sysout after changing it
> -------------------------------------------------------------------
>
> Key: FLINK-8904
> URL: https://issues.apache.org/jira/browse/FLINK-8904
> Project: Flink
> Issue Type: Bug
> Components: Client, Tests
> Affects Versions: 1.4.0, 1.5.0, 1.4.1, 1.6.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Blocker
> Fix For: 1.5.0, 1.6.0
>
>
> Several tests inside the {{org.apache.flink.client.cli}} package change
> {{System.out}} to point towards a black whole using
> {{CliFrontendTestUtils.pipeSystemOutToNull()}} but do not restore the default
> sysout after the test finishes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
