[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5662#discussion_r173881141
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
 ---
    @@ -89,9 +94,10 @@ private void testTableSource(FormatDescriptor format) {
                // construct table source using a builder
     
                final Map<String, String> tableJsonMapping = new HashMap<>();
    +           tableJsonMapping.put("name", "name");
    --- End diff --
    
    @fhueske what do you think about this whole mapping business?


---