[
https://issues.apache.org/jira/browse/FLINK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396971#comment-16396971
]
ASF GitHub Bot commented on FLINK-8906:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5671#discussion_r174142014
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -39,13 +47,27 @@
/**
* Tests for the CANCEL command.
*/
+@RunWith(Parameterized.class)
public class CliFrontendCancelTest extends TestLogger {
+ @Parameterized.Parameters(name = "Mode = {0}")
--- End diff --
Everything about introducing this parameter is duplicated in all the test
classes. I would create a common super class that does this parameter iteration
and implements the `getCli()` and `getConfiguration()` methods, instead of
having them as static methods.
> Flip6DefaultCLI is not tested in org.apache.flink.client.cli tests
> ------------------------------------------------------------------
>
> Key: FLINK-8906
> URL: https://issues.apache.org/jira/browse/FLINK-8906
> Project: Flink
> Issue Type: Bug
> Components: Client, Tests
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> Various tests in {{org.apache.flink.client.cli}} only test with the
> {{DefaultCLI}} but should also test {{Flip6DefaultCLI}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
