[ 
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406160#comment-16406160
 ] 

ASF GitHub Bot commented on FLINK-8703:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5701#discussion_r175729168
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ---
    @@ -1515,8 +1516,22 @@ public void reportPayload(ResourceID resourceID, 
Void payload) {
                }
     
                @Override
    -           public CompletableFuture<Void> retrievePayload(ResourceID 
resourceID) {
    -                   return CompletableFuture.completedFuture(null);
    +           public CompletableFuture<AccumulatorReport> 
retrievePayload(ResourceID resourceID) {
    --- End diff --
    
    Let's add `validateRunsInMainThread` as a first statement. That way we 
enforce that this method really runs in the main thread context.


> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
>                 Key: FLINK-8703
>                 URL: https://issues.apache.org/jira/browse/FLINK-8703
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to