[
https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406209#comment-16406209
]
ASF GitHub Bot commented on FLINK-8756:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5573#discussion_r175735166
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobAccumulatorsHandler.java
---
@@ -62,18 +64,33 @@ public JobAccumulatorsHandler(
}
@Override
- protected JobAccumulatorsInfo
handleRequest(HandlerRequest<EmptyRequestBody, JobMessageParameters> request,
AccessExecutionGraph graph) throws RestHandlerException {
- StringifiedAccumulatorResult[] accs =
graph.getAccumulatorResultsStringified();
- List<JobAccumulatorsInfo.UserTaskAccumulator>
userTaskAccumulators = new ArrayList<>(accs.length);
+ protected JobAccumulatorsInfo
handleRequest(HandlerRequest<EmptyRequestBody,
JobAccumulatorsMessageParameters> request, AccessExecutionGraph graph) throws
RestHandlerException {
+ JobAccumulatorsInfo accumulatorsInfo;
+ List<Boolean> queryParams =
request.getQueryParameter(AccumulatorsIncludeSerializedValueQueryParameter.class);
- for (StringifiedAccumulatorResult acc : accs) {
+ boolean includeSerializedValue = false;
--- End diff --
let's make it `final` and assign `false` in the else branch.
> Support ClusterClient.getAccumulators() in RestClusterClient
> ------------------------------------------------------------
>
> Key: FLINK-8756
> URL: https://issues.apache.org/jira/browse/FLINK-8756
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Aljoscha Krettek
> Assignee: vinoyang
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
