[ 
https://issues.apache.org/jira/browse/FLINK-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406275#comment-16406275
 ] 

ASF GitHub Bot commented on FLINK-9028:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5726#discussion_r175752251
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -409,6 +411,12 @@ public void terminateCluster(ApplicationId 
applicationId) throws FlinkException
                }
        }
     
    +   private void checkConfig(ClusterSpecification clusterSpecification) {
    --- End diff --
    
    This should throw a checked exception. Something like 
`InvalidConfigurationException` or so. But not just fail with an 
`IllegalStateException`.


> flip6 should check config before starting cluster
> -------------------------------------------------
>
>                 Key: FLINK-9028
>                 URL: https://issues.apache.org/jira/browse/FLINK-9028
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Major
>             Fix For: 1.5.0
>
>
> In flip6, we should perform parameters checking before starting cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to