Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/896#discussion_r34503586
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
 ---
    @@ -53,32 +53,34 @@
     
        private final ExecutionConfig executionConfig;
     
    -   private final HashMap<String, Accumulator<?, ?>> accumulators = new 
HashMap<String, Accumulator<?, ?>>();
    -   
    +   private final Map<String, Accumulator<?, ?>> accumulators;
    +
        private final DistributedCache distributedCache;
    -   
    -   
    +
    +
        public AbstractRuntimeUDFContext(String name,
    --- End diff --
    
    I think a common practice is to have optional arguments last, e.g. the 
cpTasks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to