Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5734#discussion_r176029020 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java --- @@ -292,6 +292,13 @@ public void start() throws Exception { throwable = ExceptionUtils.firstOrSuppressed(t, throwable); } + try { + // it will call close() recursively from the parent to children + taskManagerMetricGroup.close(); --- End diff -- I was intended to catch maybe some `RuntimeException`... I will just remove the `try catch`.
---