[ 
https://issues.apache.org/jira/browse/FLINK-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407724#comment-16407724
 ] 

ASF GitHub Bot commented on FLINK-9020:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5717#discussion_r176032646
  
    --- Diff: flink-end-to-end-tests/parent-child-classloading-test/pom.xml ---
    @@ -0,0 +1,107 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +      http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +    -->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +
    +   <parent>
    +           <artifactId>flink-end-to-end-tests</artifactId>
    +           <groupId>org.apache.flink</groupId>
    +           <version>1.6-SNAPSHOT</version>
    +           <relativePath>..</relativePath>
    +   </parent>
    +
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <artifactId>parent-child-classloading-test</artifactId>
    --- End diff --
    
    * add `flink` prefix
    * add `_${scala.binary.version}` suffix
    * add `<name>flink-parent-child-classloading-test</name>` (this is what 
allows us to omit the scala stuff when listing child modules)


> Move test projects of end-to-end tests in separate modules
> ----------------------------------------------------------
>
>                 Key: FLINK-9020
>                 URL: https://issues.apache.org/jira/browse/FLINK-9020
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Florian Schmidt
>            Assignee: Florian Schmidt
>            Priority: Major
>
> I would like to propose to move each test case in the end-to-end tests into 
> it's own module. Reason is that currently we are building all jars for the 
> tests from one pom.xml, which makes it hard to have specific tests for 
> certain build types (e.g. examples derived from the flink quickstart 
> archetype).
> For the current state this would mean
> - change packaging from flink-end-to-end-tests from jar to pom
> - refactor the classloader example to be in its own module



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to