[
https://issues.apache.org/jira/browse/FLINK-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408927#comment-16408927
]
ASF GitHub Bot commented on FLINK-8931:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5744
[FLINK-8931] TASK_KILLING is not covered by match in
TaskMonitor#whenUnhandled
## What is the purpose of the change
*This pull request makes _TASK_KILLING_ covered by match in
`TaskMonitor#whenUnhandled`*
## Brief change log
- *Added _TASK_KILLING_ in last case *
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5744
----
commit 98c754214a24ff1ee1fff31a2fdaff7dc2f0a427
Author: yanghua <yanghua1127@...>
Date: 2018-03-22T01:58:08Z
[FLINK-8931] TASK_KILLING is not covered by match in
TaskMonitor#whenUnhandled
----
> TASK_KILLING is not covered by match in TaskMonitor#whenUnhandled
> -----------------------------------------------------------------
>
> Key: FLINK-8931
> URL: https://issues.apache.org/jira/browse/FLINK-8931
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Major
>
> Noticed the following :
> {code}
> [WARNING]
> /a/flink-1.3.3/flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/TaskMonitor.scala:157:
> warning: match may not be exhaustive.
> [WARNING] It would fail on the following input: TASK_KILLING
> [WARNING] msg.status().getState match {
> [WARNING] ^
> [WARNING]
> /a/flink-1.3.3/flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/TaskMonitor.scala:170:
> warning: match may not be exhaustive.
> [WARNING] It would fail on the following input: TASK_KILLING
> [WARNING] msg.status().getState match {
> [WARNING] ^
> {code}
> It seems that TASK_KILLING should be covered by the last case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
