Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34549555 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -400,13 +398,22 @@ class JobManager(protected val flinkConfiguration: Configuration, import scala.collection.JavaConverters._ sender ! RegisteredTaskManagers(instanceManager.getAllRegisteredInstances.asScala) - case Heartbeat(instanceID, metricsReport) => - try { - log.debug(s"Received hearbeat message from $instanceID.") - instanceManager.reportHeartBeat(instanceID, metricsReport) - } catch { - case t: Throwable => log.error(s"Could not report heart beat from ${sender().path}.", t) - } + case Heartbeat(instanceID, metricsReport, accumulators) => + log.debug(s"Received hearbeat message from $instanceID.") + + Future { + accumulators foreach { + case accumulators => + currentJobs.get(accumulators.getJobID) match { --- End diff -- Yes that is true. Like you said such corner case wouldn't cause anything bad but it would log an error. So let's just do nothing in case of an unknown job id.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---