[
https://issues.apache.org/jira/browse/FLINK-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626073#comment-14626073
]
ASF GitHub Bot commented on FLINK-2292:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/896#discussion_r34549555
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -400,13 +398,22 @@ class JobManager(protected val flinkConfiguration:
Configuration,
import scala.collection.JavaConverters._
sender !
RegisteredTaskManagers(instanceManager.getAllRegisteredInstances.asScala)
- case Heartbeat(instanceID, metricsReport) =>
- try {
- log.debug(s"Received hearbeat message from $instanceID.")
- instanceManager.reportHeartBeat(instanceID, metricsReport)
- } catch {
- case t: Throwable => log.error(s"Could not report heart beat from
${sender().path}.", t)
- }
+ case Heartbeat(instanceID, metricsReport, accumulators) =>
+ log.debug(s"Received hearbeat message from $instanceID.")
+
+ Future {
+ accumulators foreach {
+ case accumulators =>
+ currentJobs.get(accumulators.getJobID) match {
--- End diff --
Yes that is true. Like you said such corner case wouldn't cause anything
bad but it would log an error. So let's just do nothing in case of an unknown
job id.
> Report accumulators periodically while job is running
> -----------------------------------------------------
>
> Key: FLINK-2292
> URL: https://issues.apache.org/jira/browse/FLINK-2292
> Project: Flink
> Issue Type: Sub-task
> Components: JobManager, TaskManager
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Fix For: 0.10
>
>
> Accumulators should be sent periodically, as part of the heartbeat that sends
> metrics. This allows them to be updated in real time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
