[ 
https://issues.apache.org/jira/browse/FLINK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415692#comment-16415692
 ] 

ASF GitHub Bot commented on FLINK-8415:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5724
  
    Changes look good to me @yanghua. Merging this PR.


> Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()
> ------------------------------------------------------------------------
>
>                 Key: FLINK-8415
>                 URL: https://issues.apache.org/jira/browse/FLINK-8415
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>
> {code}
>   public void shutdown() {
>     running = false;
>     recordsToSend.complete(0L);
> {code}
> In other methods, access to recordsToSend is protected by synchronized 
> keyword.
> shutdown() should do the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to