[ 
https://issues.apache.org/jira/browse/FLINK-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417657#comment-16417657
 ] 

ASF GitHub Bot commented on FLINK-8961:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5730#discussion_r177804924
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
 ---
    @@ -80,42 +95,38 @@ public void testJobRetrieval() throws Exception {
     
                final JobGraph jobGraph = new JobGraph(jobID, "testjob", 
imalock);
     
    -           final ClusterClient<StandaloneClusterId> client = new 
StandaloneClusterClient(cluster.configuration(), 
cluster.highAvailabilityServices(), true);
    -
                // acquire the lock to make sure that the job cannot complete 
until the job client
                // has been attached in resumingThread
                lock.acquire();
    --- End diff --
    
    Code-wise it doesn't really make a difference for Flip-6. Given that the 
job takes a little bit of time, then we should fuzzily cover both cases when 
removing the lock, though.


> Port JobRetrievalITCase to flip6
> --------------------------------
>
>                 Key: FLINK-8961
>                 URL: https://issues.apache.org/jira/browse/FLINK-8961
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to