Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/905#issuecomment-121413841
The tests look good!
I added a few minor comments in line. Nice that you also updated the
JavaDoc of `DataSet.java`. Can you update the documentation of the `distinct()`
in `DataSet.scala` as well?
After that I think this PR is good to merge.
Thanks, Fabian
Btw. I found that `distinct` is not contained in Flink's documentation and
opened https://issues.apache.org/jira/browse/FLINK-2362.
You can add distinct to the documentation in a separate PR if you are
interested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
