[ 
https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427021#comment-16427021
 ] 

ASF GitHub Bot commented on FLINK-9008:
---------------------------------------

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5823

    [FLINK-9008] [e2e] Implements quickstarts end to end test

    ## What is the purpose of the change
    Add an end-to-end test which verifies Flink's quickstarts.
    
    ## Brief change log
    1. Create a new Flink project using the quickstarts archetype []
    2. Add a new Flink dependency to the pom.xml (Flink elasticsearch connector)
    3. Add a scripts verify that program
    
    
    ## Verifying this change
    Run test_quickstarts.sh verify this change
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no )
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-9008

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5823
    
----
commit c7b86bb18358715c747e0fa12946b3cfaff86a4d
Author: zhangminglei <zml13856086071@...>
Date:   2018-04-05T14:20:17Z

    [FLINK-9008] [e2e] Implements quickstarts end to end test

----


> End-to-end test: Quickstarts
> ----------------------------
>
>                 Key: FLINK-9008
>                 URL: https://issues.apache.org/jira/browse/FLINK-9008
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Quickstarts, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> We could add an end-to-end test which verifies Flink's quickstarts. It should 
> do the following:
> # create a new Flink project using the quickstarts archetype 
> # add a new Flink dependency to the {{pom.xml}} (e.g. Flink connector or 
> library) 
> # run {{mvn clean package -Pbuild-jar}}
> # verify that no core dependencies are contained in the jar file
> # Run the program



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to