[
https://issues.apache.org/jira/browse/FLINK-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439119#comment-16439119
]
ASF GitHub Bot commented on FLINK-9176:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5851
[FLINK-9176] [build] Re-introduce category to surefire configuration
## What is the purpose of the change
The LegacyAndNew and New annotations, that were previously used to disable
tests based on whether the legacyCode profile is active, are effectively
unused. So, I re-introduce category to surefire configuration to make them work.
## Brief change log
Update parent pom.xml file.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-9176-lei
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5851.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5851
----
commit 1a053ea7c3511cd97a41681cc4d77f1e11145b93
Author: zhangminglei <zml13856086071@...>
Date: 2018-04-16T08:22:34Z
[FLINK-9176] [build] Re-introduce category to surefire configuration
----
> Category annotations are unused
> -------------------------------
>
> Key: FLINK-9176
> URL: https://issues.apache.org/jira/browse/FLINK-9176
> Project: Flink
> Issue Type: Bug
> Components: Build System, Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: mingleizhang
> Priority: Critical
> Fix For: 1.5.0
>
>
> The {{LegacyAndNew}} and {{New}} annotations, that were previously used to
> disable tests based on whether the {{legacyCode}} profile is active, are
> effectively unused.
> While several tests are annotated with them they are never used in the actual
> {{surefire}} configuration.
> We should either re-introduce them into the {{surefire}} configuration, or
> remove them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
