[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439442#comment-16439442
]
ASF GitHub Bot commented on FLINK-9179:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5856
[FLINK-9179] [conf] Fix deduplicate WebOptions.PORT and RestOptions.PORT
## What is the purpose of the change
There are deduplicate WebOptions.PORT and RestOptions.REST_PORT. Should be
solved.
## Brief change log
Deprecate WebOptions.PORT, and add a deprecated key to
RestOptions.REST_PORT.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-9179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5856
----
commit 8eb6c87cb735eaae18892ec2542076509b741690
Author: zhangminglei <zml13856086071@...>
Date: 2018-04-16T13:24:14Z
[FLINK-9179] [conf] Fix deduplicate WebOptions.PORT and RestOptions.PORT
----
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -----------------------------------------------------
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: mingleizhang
> Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
