Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5880#discussion_r182777472
  
    --- Diff: 
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoSerializerConcurrencyTest.java
 ---
    @@ -24,21 +24,71 @@
     import org.apache.flink.core.testutils.BlockerSync;
     import org.apache.flink.core.testutils.CheckedThread;
     
    +import com.esotericsoftware.kryo.Kryo;
    +import com.esotericsoftware.kryo.Serializer;
    +import com.esotericsoftware.kryo.io.Input;
    +import com.esotericsoftware.kryo.io.Output;
    +import org.junit.Assert;
     import org.junit.Test;
     
     import java.io.IOException;
    +import java.io.Serializable;
     
     import static org.junit.Assert.fail;
     
     /**
      * This tests that the {@link KryoSerializer} properly fails when accessed 
by two threads
    - * concurrently.
    + * concurrently and that Kryo serializers are properly duplicated to use 
them in different threads.
      *
      * <p><b>Important:</b> This test only works if assertions are activated 
(-ea) on the JVM
      * when running tests.
      */
     public class KryoSerializerConcurrencyTest {
     
    +   @Test
    +   public void testDuplicateSerializerWithDefaultSerializerClass() {
    --- End diff --
    
    test names are mixed up, this and the next one should be switched


---

Reply via email to