Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5555#discussion_r182218521
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -1439,7 +1467,47 @@ object AggregateUtil {
           }
         }
     
    -    (aggFieldIndexes, aggregates, accTypes, accSpecs)
    +    // create distinct accumulator filter argument
    +    val distinctAggs = new Array[Seq[DataViewSpec[_]]](aggregateCalls.size)
    --- End diff --
    
    I would not create the `MapViewSpec`s here but do that in the code gen 
function. Here we should create an `Array[Boolean]` to flag distinct 
aggregations.


---

Reply via email to