Github user tweise commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5889#discussion_r184224413
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
 ---
    @@ -86,4 +86,19 @@ protected AmazonKinesis createKinesisClient(Properties 
configProps) {
                assertEquals(10000, clientConfiguration.getSocketTimeout());
        }
     
    +   @Test
    +   public void testClientConfigOverride() {
    +
    +           Properties configProps = new Properties();
    +           configProps.setProperty(AWSConfigConstants.AWS_REGION, 
"us-east-1");
    +           configProps.setProperty(AWSUtil.AWS_CLIENT_CONFIG_PREFIX + 
"socketTimeout", "9999");
    --- End diff --
    
    The credentials construction code may be hard to replace declaratively. 
Also, the credentials are not a client config property, but a property of the 
Kinesis client.


---

Reply via email to