[ 
https://issues.apache.org/jira/browse/FLINK-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453192#comment-16453192
 ] 

ASF GitHub Bot commented on FLINK-9188:
---------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5889#discussion_r184224413
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
 ---
    @@ -86,4 +86,19 @@ protected AmazonKinesis createKinesisClient(Properties 
configProps) {
                assertEquals(10000, clientConfiguration.getSocketTimeout());
        }
     
    +   @Test
    +   public void testClientConfigOverride() {
    +
    +           Properties configProps = new Properties();
    +           configProps.setProperty(AWSConfigConstants.AWS_REGION, 
"us-east-1");
    +           configProps.setProperty(AWSUtil.AWS_CLIENT_CONFIG_PREFIX + 
"socketTimeout", "9999");
    --- End diff --
    
    The credentials construction code may be hard to replace declaratively. 
Also, the credentials are not a client config property, but a property of the 
Kinesis client.


> Provide a mechanism to configure AmazonKinesisClient in FlinkKinesisConsumer
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-9188
>                 URL: https://issues.apache.org/jira/browse/FLINK-9188
>             Project: Flink
>          Issue Type: Task
>          Components: Kinesis Connector
>            Reporter: Thomas Weise
>            Priority: Major
>
> It should be possible to control the ClientConfiguration to set socket 
> timeout and other properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to