[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458725#comment-16458725
]
ASF GitHub Bot commented on FLINK-9234:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Can we actually get rid of `commons-configuration` in the table API?
All the commons packages with their weird long tail of not properly
declared dependencies have become a bit of an anti-pattern to me over time...
> Commons Logging is missing from shaded Flink Table library
> ----------------------------------------------------------
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
> Reporter: Eron Wright
> Assignee: Timo Walther
> Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.<init>(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.<clinit>(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
