GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/5944

    [FLINK-8900] [yarn] Set correct application status when job is finished

    ## What is the purpose of the change
    
    When finite Flink applications (batch jobs) are sent to YARN in the 
detached mode, the final status is currently always the same, because the job's 
result is not passed to the logic that initiates the application shutdown.
    
    This PR forwards the final job status via a future that is used to register 
the shutdown handlers.
    
    ## Brief change log
    
      - Introduce the `JobTerminationFuture` in the `MiniDispatcher`
      - 
    
    ## Verifying this change
    
    ```
    bin/flink run -m yarn-cluster -yjm 2048 -ytm 2048  
./examples/streaming/WordCount.jar
    ```
    
      - Run the batch job as described above on YARN to succeed, check that the 
final application status is successful.
    
      - Run the batch job with a parameter to a non existing input file on 
YARN, check that the final application status is failed.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no)**
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink yarn_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5944
    
----
commit f4130c64420e2ad2acb680869c9b84aa5dbcc7c7
Author: Stephan Ewen <sewen@...>
Date:   2018-04-30T07:55:50Z

    [hotfix] [tests] Update log4j-test.properties
    
    Brings the logging definition in sync with other projects.
    Updates the classname for the suppressed logger in Netty to account for the 
new
    shading model introduced in Flink 1.4.

commit 5fcc9aca392cbcd5dfa474b0a286868b44836f23
Author: Stephan Ewen <sewen@...>
Date:   2018-04-27T16:57:27Z

    [FLINK-8900] [yarn] Set correct application status when job is finished

----


---

Reply via email to