[
https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462133#comment-16462133
]
ASF GitHub Bot commented on FLINK-9138:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r185732573
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -473,6 +482,15 @@ private boolean shouldRoll(BucketState<T> bucketState)
throws IOException {
subtaskIndex,
writePosition,
batchSize);
+ } else {
+ long currentProcessingTime =
processingTimeService.getCurrentProcessingTime();
--- End diff --
You should pass in the current processing time to avoid calling this
somewhat costly method twice.
> Enhance BucketingSink to also flush data by time interval
> ---------------------------------------------------------
>
> Key: FLINK-9138
> URL: https://issues.apache.org/jira/browse/FLINK-9138
> Project: Flink
> Issue Type: Improvement
> Components: filesystem-connector
> Affects Versions: 1.4.2
> Reporter: Narayanan Arunachalam
> Priority: Major
>
> BucketingSink now supports flushing data to the file system by size limit and
> by period of inactivity. It will be useful to also flush data by a specified
> time period. This way, the data will be written out when write throughput is
> low but there is no significant time period gaps between the writes. This
> reduces ETA for the data in the file system and should help move the
> checkpoints faster as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
