[
https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465689#comment-16465689
]
ASF GitHub Bot commented on FLINK-9276:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5954#discussion_r186376122
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -1070,13 +1071,22 @@ protected void
timeoutPendingSlotRequest(SlotRequestId slotRequestId) {
removePendingRequest(slotRequestId);
}
- private void releaseTaskManagerInternal(final ResourceID resourceId) {
- final FlinkException cause = new FlinkException("Releasing
TaskManager " + resourceId + '.');
+ private void releaseTaskManagerInternal(final ResourceID resourceId,
final Exception cause) {
--- End diff --
I think we can just use the `cause` exception and do not need to re-wrap it
into another exception.
If re-wrapping is needed for some reason, we need to add the original
exception as the cause.
> Improve error message when TaskManager fails
> --------------------------------------------
>
> Key: FLINK-9276
> URL: https://issues.apache.org/jira/browse/FLINK-9276
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Critical
>
> When a TaskManager fails, we frequently get a message
> {code}
> org.apache.flink.util.FlinkException: Releasing TaskManager
> container_1524853016208_0001_01_000102
> {code}
> This message is misleading in that it sounds like an intended operation, when
> it really is a failure of a container that the {{ResourceManager}} reports to
> the {{JobManager}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
