Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5860
  
    Hi @glaksh100, 
    
    I just noticed that the bucket closing check is only done when a record is 
written. Hence, inactive buckets might not get closed in time if a larger 
inactive bucket interval is configured. In some sense, the new feature is an 
extended version of the inactive bucket closing feature.
    
    How should we handle that case?
    
    1. throw an exception during configuration, i.e., when 
`setInactiveBucketThreshold()` and `setBatchRolloverInterval()` are called.
    2. configure the inactive bucket interval to be at least the rollover 
interval in case it is configured larger and continue. We should also make sure 
that the check interval is configured appropriately.
    
    I'm leaning towards the first approach. It would make the misconfiguration 
obvious to the user and fail the program before it is submitted.
    
    What do you think?
    
    Best, Fabian


---

Reply via email to