[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467191#comment-16467191 ]
ASF GitHub Bot commented on FLINK-8655: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5964#discussion_r186673889 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@ -429,6 +429,26 @@ public void testCassandraPojoAtLeastOnceSink() throws Exception { Assert.assertEquals(20, rs.all().size()); } + @Test + public void testCassandraPojoNoAnnotatedKeyspaceAtLeastOnceSink() throws Exception { + session.execute(CREATE_TABLE_QUERY.replace(TABLE_NAME_VARIABLE, "test2")); + + CassandraPojoSink<PojoNoAnnotatedKeyspace> sink = new CassandraPojoSink<>(PojoNoAnnotatedKeyspace.class, builder); + + Configuration configuration = new Configuration(); + configuration.setString("keyspace", "flink"); --- End diff -- this has no effect and can be removed > Add a default keyspace to CassandraSink > --------------------------------------- > > Key: FLINK-8655 > URL: https://issues.apache.org/jira/browse/FLINK-8655 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector > Affects Versions: 1.4.0 > Reporter: Christopher Hughes > Priority: Minor > Labels: features > Fix For: 1.6.0 > > > Currently, to use the CassandraPojoSink, it is necessary for a user to > provide keyspace information on the desired POJOs using datastax annotations. > This allows various POJOs to be written to multiple keyspaces while sinking > messages, but prevent runtime flexibility. > For many developers, non-production environments may all share a single > Cassandra instance differentiated by keyspace names. I propose adding a > `defaultKeyspace(String keyspace)` to the ClusterBuilder. POJOs lacking a > definitive keyspace would attempt to be loaded to the provided default. -- This message was sent by Atlassian JIRA (v7.6.3#76005)