[ 
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471113#comment-16471113
 ] 

ASF GitHub Bot commented on FLINK-8135:
---------------------------------------

Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5985#discussion_r187458764
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/SavepointPathQueryParameter.java
 ---
    @@ -28,4 +28,9 @@
        public SavepointPathQueryParameter() {
                super(KEY, MessageParameterRequisiteness.OPTIONAL);
        }
    +
    +   @Override
    +   public String getDescription() {
    +           return "Defines a path to savepoint to restore from.";
    --- End diff --
    
    " path to savepoint" -> "path of the savepoint" ?


> Add description to MessageParameter
> -----------------------------------
>
>                 Key: FLINK-8135
>                 URL: https://issues.apache.org/jira/browse/FLINK-8135
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, REST
>            Reporter: Chesnay Schepler
>            Assignee: Andrei
>            Priority: Major
>             Fix For: 1.5.0
>
>
> For documentation purposes we should add an {{getDescription()}} method to 
> the {{MessageParameter}} class, describing what this particular parameter is 
> used for and which values are accepted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to