[
https://issues.apache.org/jira/browse/FLINK-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471794#comment-16471794
]
ASF GitHub Bot commented on FLINK-9292:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5970#discussion_r187589977
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeinfo/TypeInformationTest.java
---
@@ -61,7 +61,7 @@ public void testOfGenericClassForGenericType() {
@Test
public void testOfTypeHint() {
assertEquals(BasicTypeInfo.STRING_TYPE_INFO,
TypeInformation.of(String.class));
- assertEquals(BasicTypeInfo.STRING_TYPE_INFO,
TypeInformation.of(new TypeHint<String>(){}));
+ assertEquals(BasicTypeInfo.STRING_TYPE_INFO, Types.STRING);
--- End diff --
Please undo this one, the test explicitly tests the TypeHint use.
> Remove TypeInfoParser
> ---------------------
>
> Key: FLINK-9292
> URL: https://issues.apache.org/jira/browse/FLINK-9292
> Project: Flink
> Issue Type: Task
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> The {{TypeInfoParser}} has been deprecated, in favor of the {{TypeHint}}.
> Because the TypeInfoParser is also not working correctly with respect to
> classloading, we should remove it. Users still find the class, try to use it,
> and run into problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
