Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r187648458 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --- @@ -374,8 +384,8 @@ void setOffsetsToCommit( * <p>This method is exposed for testing purposes. */ @VisibleForTesting - void reassignPartitions(List<KafkaTopicPartitionState<TopicPartition>> newPartitions) throws Exception { - if (newPartitions.size() == 0) { + void reassignPartitions(List<KafkaTopicPartitionState<TopicPartition>> newPartitions, List<TopicPartition> partitionsToBeRemoved) throws Exception { + if (newPartitions.size() == 0 && partitionsToBeRemoved.isEmpty()) { --- End diff -- size() -> ! isEmpty
---