[ 
https://issues.apache.org/jira/browse/FLINK-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472286#comment-16472286
 ] 

ASF GitHub Bot commented on FLINK-8982:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5807#discussion_r187675826
  
    --- Diff: 
flink-end-to-end-tests/test-scripts/test_queryable_state_restart_tm.sh ---
    @@ -0,0 +1,120 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +source "$(dirname "$0")"/common.sh
    +source "$(dirname "$0")"/queryable_state_base.sh
    +
    
+QUERYABLE_STATE_SERVER_JAR=${TEST_INFRA_DIR}/../../flink-end-to-end-tests/flink-queryable-state-test/target/QsStateProducer.jar
    
+QUERYABLE_STATE_CLIENT_JAR=${TEST_INFRA_DIR}/../../flink-end-to-end-tests/flink-queryable-state-test/target/QsStateClient.jar
    +
    +#####################
    +# Test that queryable state works as expected with HA mode when restarting 
a taskmanager
    +#
    +# The general outline is like this:
    +# 1. start cluster in HA mode with 1 TM
    +# 2. start a job that exposes queryable state from a mapstate with 
increasing num. of keys
    +# 3. query the state with a queryable state client and expect no error to 
occur
    +# 4. stop the TM
    +# 5. check how many keys were in our mapstate at the time of the latest 
snapshot
    +# 6. start a new TM
    +# 7. query the state with a queryable state client and retrieve the number 
of elements
    +#    in the mapstate
    +# 8. expect the number of elements in the mapstate after restart of TM to 
be > number of elements
    +#    at last snapshot
    +#
    +# Globals:
    +#   QUERYABLE_STATE_SERVER_JAR
    +#   QUERYABLE_STATE_CLIENT_JAR
    +# Arguments:
    +#   None
    +# Returns:
    +#   None
    +#####################
    +function run_test() {
    +    local EXIT_CODE=0
    +    local PARALLELISM=1 # parallelism of queryable state app
    +    local PORT="9069" # port of queryable state server
    +
    +    clean_stdout_files # to ensure there are no files accidentally left 
behind by previous tests
    +    link_queryable_state_lib
    +    start_ha_cluster
    --- End diff --
    
    We do not need an HA cluster. A normal cluster would be enough.


> End-to-end test: Queryable state
> --------------------------------
>
>                 Key: FLINK-8982
>                 URL: https://issues.apache.org/jira/browse/FLINK-8982
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Queryable State, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Florian Schmidt
>            Priority: Blocker
>             Fix For: 1.6.0, 1.5.1
>
>
> We should add an end-to-end test which verifies that {{Queryable State}} is 
> working.
> [~florianschmidt] and [~kkl0u] could you please provide more details for the 
> description.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to