Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35193777 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -688,16 +688,15 @@ class JobManager( case RequestAccumulatorResults(jobID) => try { - val accumulatorValues: java.util.Map[String, SerializedValue[Object]] = { - currentJobs.get(jobID) match { - case Some((graph, jobInfo)) => - graph.getAccumulatorsSerialized - case None => - null // TODO check also archive - } + currentJobs.get(jobID) match { + case Some((graph, jobInfo)) => + val accumulatorValues = graph.getAccumulatorsSerialized + sender() ! AccumulatorResultsFound(jobID, accumulatorValues) + case None => + // TODO check also archive + sender() ! AccumulatorResultsNotFound(jobID) --- End diff -- Why not properly resolving the TODO?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---