Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/5982
  
    Hi @StephanEwen Thank you very much for your reply, I'm not sure whether 
just overriding `close()` to do `super.close()` + `rename()` is enough, for 
example.
    ```
    try (outputStream = new TwoPhraseFSDatautputStream(...)) {
        outputStream.write("part1");
        throw new RuntimeException("xxx");
        outputStream.write("part2");
    }
    ```
    This will also rename the `tmp file` to the `target file`, because we just 
`rename()` in `close()`. And the current `TwoPhraseFSDatautputStream` works as 
a wrapper so it should have supported all the file system. I'm not sure whether 
I misunderstand what your meaning... please let knows if I misunderstand 
something and your opinion, Thanks!



---

Reply via email to