[ https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636591#comment-14636591 ]
ASF GitHub Bot commented on FLINK-2388: --------------------------------------- Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35195856 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -688,16 +688,15 @@ class JobManager( case RequestAccumulatorResults(jobID) => try { - val accumulatorValues: java.util.Map[String, SerializedValue[Object]] = { - currentJobs.get(jobID) match { - case Some((graph, jobInfo)) => - graph.getAccumulatorsSerialized - case None => - null // TODO check also archive - } + currentJobs.get(jobID) match { + case Some((graph, jobInfo)) => + val accumulatorValues = graph.getAccumulatorsSerialized + sender() ! AccumulatorResultsFound(jobID, accumulatorValues) + case None => + // TODO check also archive + sender() ! AccumulatorResultsNotFound(jobID) --- End diff -- I've updated the pull request. > JobManager should try retrieving jobs from archive > -------------------------------------------------- > > Key: FLINK-2388 > URL: https://issues.apache.org/jira/browse/FLINK-2388 > Project: Flink > Issue Type: Task > Components: JobManager > Reporter: Enrique Bautista Barahona > > I was following the quickstart guide with the WordCount example and, when I > entered the "analyze" page for the job, nothing came up. Apparently the > JobManagerInfoServlet fails with a NullPointerException. > I've been reading the code and I've seen the problem is in the processing of > the RequestAccumulatorResultsStringified message in JobManager. There's a > TODO where the accumulators should be retrieved from the archive. > As I wanted to know more about Flink internals, I decided to try and fix it. > I've later seen that there's currently ongoing work in that part of the code, > so I guess maybe it's not needed, but if you want I could submit a PR. If you > have already taken it into account and will solve it shortly, please feel > free to close the issue. > If you want to take a look, the commit is here: > https://github.com/ebautistabar/flink/commit/8536352b21fb6c78ad8840b0397509df04358c6b -- This message was sent by Atlassian JIRA (v6.3.4#6332)