[
https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474463#comment-16474463
]
Rong Rong commented on FLINK-8866:
----------------------------------
I think they should be designed to use in both source and sink cases. It
doesn't really make sense to separate them, at least not in [~twalthr]'s Kafka
example and I don't really think there's any difference for others either. The
only thing I can think of is security/authorization concern: E.g. whether
sharing configurations for real-only access and write access in the same
location is safe or not. [~suez1224] what do you think?
I haven't implement the "both" part, this diff is merely trying to clear some
questions I had for implementing FLINK-8880. Also, there's some components
which I think can definitely be unified in Table API level, such as the
Source/Sink Factory service. It can make the APIs more unified. What do you
guys think?
--
Rong
> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
> Key: FLINK-8866
> URL: https://issues.apache.org/jira/browse/FLINK-8866
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure
> and instantiate TableSinks. Among other applications, this is necessary in
> order to declare table sinks in an environment file of the SQL client. Such
> that the sink can be used for {{INSERT INTO}} statements.
> Below are a few major changes in mind.
> 1) Add TableSinkFactory/TableSinkFactoryService similar to
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both)
> for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to
> identify whether it's source or sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
