[
https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475318#comment-16475318
]
ASF GitHub Bot commented on FLINK-9325:
---------------------------------------
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5982
Hi @StephanEwen, I added more tests for the
`FileSystem#createAtomically()`, concerning the `TwoPhaseFsDataoutputStream`,
can we introduce a `commit_on_close` option for it to make it easier to use? If
the `commit_on_close=true`, we commit the writing in `close()` atomically. If
the `commit_on_close=false`, we need user to call `commit()` manually, this
could be useful in try-with-resource situation, what do you think?
> generate the _meta file for checkpoint only when the writing is truly
> successful
> --------------------------------------------------------------------------------
>
> Key: FLINK-9325
> URL: https://issues.apache.org/jira/browse/FLINK-9325
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
>
> We should generate the _meta file for checkpoint only when the writing is
> totally successful. We should write the metadata file first to a temp file
> and then atomically rename it (with an equivalent workaround for S3).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
