[GitHub] flink pull request #6035: [FLINK-6160] Add reconnection attempts in case of ...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6035#discussion_r189013436
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ---
    @@ -947,6 +964,36 @@ private void closeResourceManagerConnection(Exception 
cause) {
                        resourceManagerConnection.close();
                        resourceManagerConnection = null;
                }
    +
    +           startRegistrationTimeout();
    --- End diff --
    
    It looks weird that we call `startRegistrationTimeout();` in 
`closeResourceManagerConnection`. Can it be done in 
`createResourceManagerConnection`


---