[ 
https://issues.apache.org/jira/browse/FLINK-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480000#comment-16480000
 ] 

ASF GitHub Bot commented on FLINK-8838:
---------------------------------------

Github user suez1224 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5619#discussion_r189145367
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/AggregateITCase.scala
 ---
    @@ -367,6 +367,36 @@ class AggregateITCase(
         TestBaseUtils.compareResultAsText(result.asJava, expected)
       }
     
    +  @Test
    +  def testTumbleWindowAggregateWithCollectUnnest(): Unit = {
    --- End diff --
    
    Can we just not use COLLECT to construct the test samples? In general, a 
unittest should test one thing a time, not multiple. And also for the streaming 
case.


> Add Support for UNNEST a MultiSet type field
> --------------------------------------------
>
>                 Key: FLINK-8838
>                 URL: https://issues.apache.org/jira/browse/FLINK-8838
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: lincoln.lee
>            Assignee: lincoln.lee
>            Priority: Major
>
> MultiSetTypeInfo was introduced by  FLINK-7491, and UNNEST support Array type 
> only,  so it would be nice to support UNNEST a MultiSet type field.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to