[ 
https://issues.apache.org/jira/browse/FLINK-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482080#comment-16482080
 ] 

ASF GitHub Bot commented on FLINK-9398:
---------------------------------------

GitHub user walterddr opened a pull request:

    https://github.com/apache/flink/pull/6049

    [FLINK-9398][Client] Fix CLI list running job returns all except scheduled 
jobs

    
    
    ## What is the purpose of the change
    
    This PR fixes CLI command `bin/flink list -r` returning all except 
scheduled jobs.
    
    
    ## Brief change log
    
    Change the behavior of `bin/flink list` to
      - Adding in a `-a` option to list all jobs. Including `CREATED`, 
`RUNNING` & `RESTARTING`
      - Fixing `-r` option to list only `RUNNING` and `RESTARTING`.
      - Internally map `-a` with `other` job type so it won't affect the 
behavior of explicit listing options when adding other options to `list` 
command.
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Added unit-test to verify `-a` options.
      - Added `ListOptions` unit-test suite which never existed before.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? documented in `cli.md`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/walterddr/flink FLINK-9398

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6049
    
----
commit d742f3ec5ffd4b411162db234e108a496a4f5aaa
Author: Rong Rong <walter_ddr@...>
Date:   2018-05-20T14:29:56Z

    fix CLI list options showing all jobs instead of just running / restarting 
jobs

commit e6d827700427a3f31a699ff02cb5b9906715c629
Author: Rong Rong <walter_ddr@...>
Date:   2018-05-20T23:45:18Z

    adding in documentation for list all jobs option

----


> Flink CLI list running job returns all jobs except in CREATE state
> ------------------------------------------------------------------
>
>                 Key: FLINK-9398
>                 URL: https://issues.apache.org/jira/browse/FLINK-9398
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> See: 
> https://github.com/apache/flink/blob/4922ced71a307a26b9f5070b41f72fd5d93b0ac8/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L437-L445
> Seems like CLI command: *flink list -r* returns all jobs except jobs in 
> *CREATE* state. which conflicts with the CLI description: *Running/Restarting 
> Jobs*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to