[ 
https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484117#comment-16484117
 ] 

Xingcan Cui commented on FLINK-9219:
------------------------------------

Hi [~twalthr], I cannot think out why the static method {{bind()}} was designed 
to be {{protected}}, but as you said, the private constructor makes it 
impossible to extend {{GeoFunctions}}. Actually, besides, the constant 
{{NO_SRID}} used by one of {{Geom}}'s implementation is also private and not 
all the Geo functions are implemented as interface-oriented (e.g., 
{{ST_Point(BigDecimal x, BigDecimal y, BigDecimal z)}} directly creates a 
{{SimpleGeom}}). Considering the {{GeoFunctions}} in Calcite is marked as 
{{Experimental}}, I suggest to add a switch (and makes it off by default) for 
using these functions in Flink. Do we have some previous case like that?

> Add support for OpenGIS features in Table & SQL API
> ---------------------------------------------------
>
>                 Key: FLINK-9219
>                 URL: https://issues.apache.org/jira/browse/FLINK-9219
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>            Priority: Major
>
> CALCITE-1968 added core functionality for handling 
> spatial/geographical/geometry data. It should not be too hard to expose these 
> features also in Flink's Table & SQL API. We would need a new {{GEOMETRY}} 
> data type and connect the function APIs.
> Right now the following functions are supported by Calcite:
> {code}
> ST_AsText, ST_AsWKT, ST_Boundary, ST_Buffer, ST_Contains, 
> ST_ContainsProperly, ST_Crosses, ST_Disjoint, ST_Distance, ST_DWithin, 
> ST_Envelope, ST_EnvelopesIntersect, ST_Equals, ST_GeometryType, 
> ST_GeometryTypeCode, ST_GeomFromText, ST_Intersects, ST_Is3D, 
> ST_LineFromText, ST_MakeLine, ST_MakePoint, ST_MLineFromText, 
> ST_MPointFromText, ST_MPolyFromText, ST_Overlaps, ST_Point, ST_PointFromText, 
> ST_PolyFromText, ST_SetSRID, ST_Touches, ST_Transform, ST_Union, ST_Within, 
> ST_Z
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to