[ 
https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486739#comment-16486739
 ] 

ASF GitHub Bot commented on FLINK-7386:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6043#discussion_r190126862
  
    --- Diff: 
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/BulkProcessorIndexer.java
 ---
    @@ -45,12 +48,34 @@
        }
     
        @Override
    -   public void add(ActionRequest... actionRequests) {
    -           for (ActionRequest actionRequest : actionRequests) {
    +   public void add(DeleteRequest... deleteRequests) {
    +           for (DeleteRequest deleteRequest : deleteRequests) {
                        if (flushOnCheckpoint) {
                                numPendingRequestsRef.getAndIncrement();
                        }
    -                   this.bulkProcessor.add(actionRequest);
    +                   this.bulkProcessor.add(deleteRequest);
    +           }
    +   }
    +
    +   @Override
    +   public void add(IndexRequest... indexRequests) {
    +           for (IndexRequest indexRequest : indexRequests) {
    +                   System.out.println("ir: " + indexRequest);
    --- End diff --
    
    Leftover print.


> Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ 
> client
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-7386
>                 URL: https://issues.apache.org/jira/browse/FLINK-7386
>             Project: Flink
>          Issue Type: Improvement
>          Components: ElasticSearch Connector
>            Reporter: Dawid Wysakowicz
>            Assignee: Fang Yong
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> In Elasticsearch 5.2.0 client the class {{BulkProcessor}} was refactored and 
> has no longer the method {{add(ActionRequest)}}.
> For more info see: https://github.com/elastic/elasticsearch/pull/20109



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to